Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug progress bar #4719

Closed
heliosburner opened this issue May 13, 2024 · 7 comments
Closed

Bug progress bar #4719

heliosburner opened this issue May 13, 2024 · 7 comments
Labels
stale Issues that are old and soon to be closed

Comments

@heliosburner
Copy link

wait what1

The bug in question:
The progress bar shows 161k for yes , when there's 2 yes votes down there with 155k and 123k which when combined is 278k, not 161k.
Either a lag/update bug or a visual bug on either one of the yes votes or the progress bar.
Found on the LIVE Aavegotchi proposals accidentally while testing something.

@heliosburner
Copy link
Author

heliosburner commented May 13, 2024

@ChaituVR

This comment was marked as outdated.

@heliosburner
Copy link
Author

Hello @ChaituVR There's about 8 tokens to calculate so I was thinking this might results in 8 updates per vote instead of just one calculation. The final calculation update shoulde be accurate unless an error message appears? so it's fine if I delete it or shall we keep it up to see if the final score coincidences with all the votes?

@ChaituVR
Copy link
Member

Hi @heliosburner, Sorry i overlooked it earlier, looks like there is no issue with the score calculation. but proposal is using quadratic voting, https://docs.snapshot.org/user-guides/proposals/voting-types#quadratic-voting

@heliosburner
Copy link
Author

There's been calculation problems with quadratic voting in the past? They're useful in case an address contains over 500 people voting such as a DAO address. Temporarily the image shows there might be an issue, even if the final calculation will be correct.
If you looked on that page's source and saw no code issue with the score calculation then let me know so I may delete the proposal and mark this bug issue as fixed on Github.

@ChaituVR
Copy link
Member

Hi @heliosburner I don't think there is a error in score calculation, looks like you are using quadratic voting and It is expected that it reduces some voting power from whales, look at implementation here https://docs.snapshot.org/user-guides/proposals/voting-types#quadratic-voting

I just checked other proposals in this space, they are all using weighted voting, maybe you selected quadratic voting wrongly?

Copy link

stale bot commented Sep 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that are old and soon to be closed label Sep 12, 2024
@stale stale bot closed this as completed Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that are old and soon to be closed
Projects
None yet
Development

No branches or pull requests

2 participants