From a33638ab9b6f71b389a9ade4803d338e77dd8a7b Mon Sep 17 00:00:00 2001 From: Parham Alvani Date: Thu, 30 Nov 2023 15:37:31 +0000 Subject: [PATCH] feat: increase test coverage --- internal/authenticator/builder.go | 6 ++-- .../authenticator/builder_internal_test.go | 30 +++++++++++++++++++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/internal/authenticator/builder.go b/internal/authenticator/builder.go index 6b54810..aca5406 100644 --- a/internal/authenticator/builder.go +++ b/internal/authenticator/builder.go @@ -115,11 +115,11 @@ func (b Builder) GetAllowedAccessTypes(accessTypes []string) []acl.AccessType { // toUserAccessType will convert string access type to it's own type. func toUserAccessType(access string) (acl.AccessType, error) { switch access { - case "pub": + case "pub", "publish": return acl.Pub, nil - case "sub": + case "sub", "subscribe": return acl.Sub, nil - case "pubsub": + case "pubsub", "subpub": return acl.PubSub, nil } diff --git a/internal/authenticator/builder_internal_test.go b/internal/authenticator/builder_internal_test.go index 5617cc1..ac5a0ae 100644 --- a/internal/authenticator/builder_internal_test.go +++ b/internal/authenticator/builder_internal_test.go @@ -24,6 +24,36 @@ func TestToUserAccessType(t *testing.T) { expected: acl.Pub, expectedErr: nil, }, + { + name: "success", + input: "publish", + expected: acl.Pub, + expectedErr: nil, + }, + { + name: "success", + input: "sub", + expected: acl.Sub, + expectedErr: nil, + }, + { + name: "success", + input: "subscribe", + expected: acl.Sub, + expectedErr: nil, + }, + { + name: "success", + input: "pubsub", + expected: acl.PubSub, + expectedErr: nil, + }, + { + name: "success", + input: "subpub", + expected: acl.PubSub, + expectedErr: nil, + }, { name: "failed", input: "-",