Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustix version #147

Closed
wants to merge 3 commits into from
Closed

Conversation

rodoufu
Copy link

@rodoufu rodoufu commented Sep 7, 2023

Version 1.12.1

  • Update rustix

@rodoufu rodoufu marked this pull request as ready for review September 7, 2023 20:38
@rodoufu
Copy link
Author

rodoufu commented Sep 7, 2023

openbsd is failing with:

package `clap_lex v0.5.1` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.68.0
Either upgrade to rustc 1.70.0 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `clap_lex` supporting rustc 1.68.0

Since it is installed with pkg_add and not rustup I'm not quite sure how to fix that.

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenBSD build error is fixed in #142.

Is there anything noteworthy in Rustix v0.38.11 that justifies upgrading to it? If not I'd rather avoid merging this, since Cargo will automatically select later versions of Rustix in the same breaking release given the option.

@taiki-e
Copy link
Collaborator

taiki-e commented Sep 10, 2023

I would prefer not to raise the minimal versions unless they fail to compile with the current minimal versions of the dependencies.

cargo's "x.y.z" requirement means "^x.y.z" (caret) requirement, and the user can just run cargo update to get the latest semver-compatible version.

So, I'll close this, but thanks for the PR anyway.

@taiki-e taiki-e closed this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants