Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blake2-rfc no longer maintained - change to blake2 #1885

Open
DragonDev1906 opened this issue Jun 20, 2024 · 2 comments
Open

blake2-rfc no longer maintained - change to blake2 #1885

DragonDev1906 opened this issue Jun 20, 2024 · 2 comments

Comments

@DragonDev1906
Copy link
Contributor

DragonDev1906 commented Jun 20, 2024

The blake2-rfc dependency hasn't been updated in 3 years, has outdated dependencies and open PRs for those. To me this looks like it is no longer maintained. How about switching to https://crates.io/crates/blake2 (RustCrypto)?

EDIT:
The same goes for the libsecp256k1 dependency (no updates since 1 year and open dependency update PRs): https://github.com/paritytech/libsecp256k1/pullshttps://github.com/RustCrypto/elliptic-curves/tree/master/k256

@tomaka
Copy link
Contributor

tomaka commented Jun 20, 2024

I fundamentally disagree that because a library doesn't get updated means that we should no longer use it.
If anything, a library not getting any update can be a sign of stability/maturity.

@DragonDev1906
Copy link
Contributor Author

That is true. It also leads to increased compile times due to the use of outdated transitive dependencies (even though there is a PR for it) and does not explain why a simple PR updating the readme is over 5 years old and didn't even get a comment.

Besides that there is also a benefit of using a library that has 5x as many users/downloads, especially for security relevant dependencies and the knowledge that if there is an issue it is more likely to get fixed.

In the end it is up to you, I hope you have considered both and actively decided to stay on blake2-rfc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants