Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance regression in JsonSchemaConverter between 1.51.0 and 1.52.0 #2429

Closed
ghostbuster91 opened this issue Oct 23, 2024 · 0 comments · Fixed by #2435
Closed

performance regression in JsonSchemaConverter between 1.51.0 and 1.52.0 #2429

ghostbuster91 opened this issue Oct 23, 2024 · 0 comments · Fixed by #2435

Comments

@ghostbuster91
Copy link
Contributor

Hi,

While updating from 1.51.0 to 1.52.0 we noticed that one of our operation started to take significantly more time (approximately 10 times more). After some debugging and profiling it turned out to be related to the recent change in JsonSchemaConverter.

We worked it around by minimizing the model to only relevant shapes before passing it to JsonSchemaConverter. Previously we were passing there the full model which is quite big (around 12k shapes).

Maybe there are some optimizations that could be applied to scrubTraitDefinitions to make it faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant