Observability Adjustments #217

jterapin · 2024-08-23T05:43:19Z

Description of changes:

Move current_span from ContextManager to Tracer
Move otel_loaded check from Telemetry module to OTelProvider
Add changelog entry (missing from initial PR)
In a context of generating span attributes, make SendMiddleware transport-agnostic.
Update InterceptorContext with a new attribute, tracer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…iddleware transport agnostic

hearth/lib/hearth/middleware/send.rb

This reverts commit ab0d9b4.

alextwoods

Looks good, just one minor comment

hearth/lib/hearth/http/request.rb

jterapin added 6 commits August 22, 2024 21:09

Move current_span to Tracer interface

bd9b0a9

Move otel_loaded check to OTelProvider

005024b

Add changelog entry

748a26d

Update documentation

030cccb

Move span attributes to http request and http response to make send m…

73d7ce8

…iddleware transport agnostic

Remove api private flag

fa2b756

alextwoods reviewed Aug 23, 2024

View reviewed changes

hearth/lib/hearth/middleware/send.rb Show resolved Hide resolved

jterapin added 3 commits August 23, 2024 09:00

Able to access telemetry provider fron interceptor context

ab0d9b4

Revert "Able to access telemetry provider fron interceptor context"

c5fb7fa

This reverts commit ab0d9b4.

Able to access tracer from interceptor context

a25c263

jterapin marked this pull request as ready for review August 23, 2024 17:25

jterapin mentioned this pull request Aug 23, 2024

V4 Observability Adjustments alextwoods/aws-sdk-ruby-v4#61

Merged

alextwoods approved these changes Aug 23, 2024

View reviewed changes

hearth/lib/hearth/http/request.rb Show resolved Hide resolved

Update based on feedback

d156409

jterapin merged commit 4853737 into main Aug 23, 2024
25 of 26 checks passed

jterapin deleted the observability_adjustments branch August 23, 2024 19:14

Provide feedback