Refactor benchmarking + fix related warnings and issues #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
changed the title
mullermp
commented
Jul 27, 2024
| @@ -508,7 +508,8 @@ RubyImportContainer.CGI, getRubyArrayFromList(queryParams)) | |||
| .write("actual_query = $T.parse(request.uri.query)", | |||
| RubyImportContainer.CGI) | |||
| .openBlock("expected_query.each do |k, v|") | |||
| .write("expect(actual_query[k]).to eq(v)") | |||
| .write("actual = actual_query[k].map { |s| s.force_encoding('utf-8') }") | |||
There was a problem hiding this comment.
Not 100% on this one, but looks like query params are only ASCII but protocol tests are UTF-8, so I think no change to our actual builders but instead just compare what we would have sent as utf-8. Doing this in reverse has a frozen string error.
|
We did not have jruby on CI .. had to do some misc work to fix that build. |
alextwoods
reviewed
Jul 29, 2024
alextwoods
reviewed
Jul 29, 2024
This reverts commit f199b7b.
alextwoods
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors benchmarking to use the shared tooling