Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stringArray parameters + operationContextParams #203

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

alextwoods
Copy link
Contributor

Description of changes:
Add support for stringArray parameters + operationContextParams.
See:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a diff of what the generated code will look like from the endpoints tests (we don't commit them... but I really think they should be in projections for cases like this)

@@ -49,7 +49,9 @@ module Endpoint
end
end
interceptor = Hearth::Interceptor.new(read_before_transmit: proc)
client.endpoint_operation({}, interceptors: [interceptor])
client.endpoint_operation({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally minor but can we handle this?

@alextwoods alextwoods merged commit 26941cf into main Jun 25, 2024
22 checks passed
@alextwoods alextwoods deleted the stringArray branch June 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants