Service Integrations (specify integrations in smithy-build.json) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullermp
reviewed
Jul 5, 2023
| @@ -75,7 +75,8 @@ public GenerationContext createContext(CreateContextDirective<RubySettings, Ruby | |||
| Model model = directive.model(); | |||
| List<RubyIntegration> integrations = directive.integrations().stream() | |||
| .filter((integration) -> integration | |||
| .includeFor(service, model)) | |||
| .includeFor(service, model) | |||
There was a problem hiding this comment.
I think it should be one or the other. If we still need the other approach then maybe we shouldn't do this one.
There was a problem hiding this comment.
Yeah, the includeFor is much more generic and necessary for a lot of cases (eg: an integration that provides behavior for a trait where there are related config values - we don't want to add those to services that don't have the trait).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Allows integrations to be specified in the smithy-build.json using a new
integrationconfig. This allows service specific integrations - but doesn't limit the flexibility of theincludeForfor plugins that need to inspect the model (eg, integrations that check for presence of a certain trait on the model).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.