Add support for Runtime Plugins #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: Render the additions in Client. Update ClientGenerator to add dup
mullermp
reviewed
Jun 27, 2023
codegen/projections/high_score_service/lib/high_score_service/config.rb
Outdated
Show resolved
Hide resolved
codegen/projections/high_score_service/lib/high_score_service/client.rb
Outdated
Show resolved
Hide resolved
codegen/smithy-ruby-codegen-test/integration-specs/plugin_spec.rb
Outdated
Show resolved
Hide resolved
...n/smithy-ruby-codegen/src/main/java/software/amazon/smithy/ruby/codegen/RubyIntegration.java
Show resolved
Hide resolved
...smithy-ruby-codegen/src/main/java/software/amazon/smithy/ruby/codegen/RubyRuntimePlugin.java
Outdated
Show resolved
Hide resolved
...smithy-ruby-codegen/src/main/java/software/amazon/smithy/ruby/codegen/RubyRuntimePlugin.java
Outdated
Show resolved
Hide resolved
codegen/projections/high_score_service/lib/high_score_service/client.rb
Outdated
Show resolved
Hide resolved
…uginList from itself
mullermp
reviewed
Jun 30, 2023
codegen/projections/high_score_service/lib/high_score_service/config.rb
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/ruby/codegen/integrations/WhiteLabelTestIntegration.java
Show resolved
Hide resolved
...smithy-ruby-codegen/src/main/java/software/amazon/smithy/ruby/codegen/RubyRuntimePlugin.java
Outdated
Show resolved
Hide resolved
mullermp
approved these changes
Jul 5, 2023
codegen/smithy-ruby-codegen-test/integration-specs/plugin_spec.rb
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/ruby/codegen/middleware/MiddlewareBuilder.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Runtime plugins allow modification of Config during client initialization and during operation invocation.
Plugins can be added at the Client class level by code generation (specifically by RubyIntegrations) or by users through Config or when calling an operation.
Testing
Testing plugin codegen changes is difficult with the existing setup - this PR adds a new test project which has a RubyIntegration which adds plugin and middleware that apply to generation of the WhiteLabel service/SDK, which allows us to write integration specs for it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.