Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested Components #4

Closed
vv-monsalve opened this issue Nov 25, 2020 · 1 comment
Closed

Nested Components #4

vv-monsalve opened this issue Nov 25, 2020 · 1 comment

Comments

@vv-monsalve
Copy link

vv-monsalve commented Nov 25, 2020 •
edited
Loading

Taken from the FB checks performed after PR #2573 was updated pointing at Version 1.110-2.

Component referring to another component (nested) could lead to some Issues. Please decompose the components to avoid having them.

This Fail is related to the Outline Quality Checklist, please inspect it and make sure your font is ready by fulfilling it.

🔥 FAIL: Check glyphs do not have components which are themselves components. 
--- Rationale ---
ve been bugs rendering variable fonts with nested components. Additionally,
some static fonts with nested components have been reported to have rendering
and printing issues. (See googlefonts/fontbakery#2961 and
arrowtype/recursive#412.)
  • 🔥 FAIL The following glyphs have components which themselves are component glyphs:
    • quotedblleft
    • quotedblleft
    • quotedblright
    • quotedblbase
    • Iacute
    • Ograve
    • iacute
    • oacute
    • ugrave
    • uacute and 90 more. [code: found-nested-components]
santhoshtr added a commit that referenced this issue Nov 28, 2020
@santhoshtr
Flatten the nested components
ee2e25d 
See #4

As a side effect this, the openTypeOS2WinDescent value had to be
adjusted to pass fontbakery test
@vv-monsalve
Copy link
Author

There is a newly implemented fontmake flag -f for flattening components that could help with this in further occasions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vv-monsalve