Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-770] fix a bug of builder ignoring docker networks passed to it #806

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Dec 21, 2023

@Tofel Tofel marked this pull request as ready for review December 21, 2023 19:41
@Tofel Tofel requested review from sebawo and a team as code owners December 21, 2023 19:41
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ca2413) 17.68% compared to head (ce0118c) 17.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   17.68%   17.68%           
=======================================
  Files          32       32           
  Lines        4206     4206           
=======================================
  Hits          744      744           
  Misses       3386     3386           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tofel Tofel merged commit 912c06a into main Dec 21, 2023
16 checks passed
@Tofel Tofel deleted the tt_770_fix_docker_networks_eth_builder branch December 21, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants