[TT-551] Stops Instant Transaction Confirmers from Blocking #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
approved these changes
Nov 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 30.94% 30.96% +0.01%
==========================================
Files 41 41
Lines 5354 5352 -2
==========================================
Hits 1657 1657
+ Misses 3517 3515 -2
Partials 180 180 ☔ View full report in Codecov by Sentry. |
tateexon
approved these changes
Nov 16, 2023
…framework into fixInstantTx
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
newHeaderChanwas used to help speed up confirmations; problem is that on fast chains, it would end up blocking confirmations for the whole test. This is a little slower to confirm transactions, but much simpler, and frankly the speed difference is negligible.