Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citool: Rename workflows to triggers #1152

Conversation

lukaszcl
Copy link
Contributor

@lukaszcl lukaszcl commented Sep 24, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes focus on standardizing terminology and functionality related to how tests are triggered within the CI tool. By replacing the term "Workflows" with "Triggers", the modifications aim to clarify the mechanism that initiates test execution, making it more intuitive for users to understand and configure their CI pipelines. This adjustment enhances the readability and maintainability of the codebase by ensuring consistency in the naming conventions used across the tool.

What

  • tools/citool/cmd/csv_export_cmd.go

    • Changed CSV header from "Workflows" to "Triggers" and updated variable names accordingly. This change affects how test configuration data is exported to CSV, making the output more accurately reflect the terminology used in the CI tool.
    • Effect: Aligns exported CSV column headers with the updated terminology, improving clarity for users.
  • tools/citool/cmd/filter_cmd.go

    • Updated the filter logic to match tests based on "Triggers" instead of "Workflows". This modification impacts how tests are selected for execution based on specified criteria such as workflow names or triggers.
    • Effect: Ensures that the filtering feature operates with the updated terminology, maintaining the functionality's integrity.
  • tools/citool/cmd/filter_cmd_test.go

    • Adjusted test cases to use "Triggers" instead of "Workflows". This change is necessary to ensure that unit tests accurately assess the functionality of the filtering logic with the new terminology.
    • Effect: Keeps unit tests in sync with the application logic, verifying that changes do not break existing functionality.
  • tools/citool/cmd/types.go

    • Modified the CITestConf struct to replace "Workflows" with "Triggers" in both the field name and the comment description. This alteration reflects the broader change in terminology throughout the codebase.
    • Effect: Updates the internal data model to be consistent with the new naming convention, aiding in code comprehension and future maintenance.

@cl-sonarqube-production
Copy link

@lukaszcl lukaszcl merged commit 83100a8 into main Sep 24, 2024
47 checks passed
@lukaszcl lukaszcl deleted the TT-1737-Rename-workflows-to-triggers-in-e2e-tests.yml-to-better-reflect-automatic-triggers branch September 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants