Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GetEndpointFromPort to utils #1127

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Adding GetEndpointFromPort to utils #1127

merged 4 commits into from
Sep 9, 2024

Conversation

patrickhuie19
Copy link
Collaborator

@patrickhuie19 patrickhuie19 commented Sep 6, 2024 •
edited
Loading

To add additional exposed ports to node containers, like in smartcontractkit/ccip#1361. Without this additional API, the testing framework will pick an arbitrary exposed port as the Operator UI

@patrickhuie19 patrickhuie19 requested review from sebawo and a team as code owners September 6, 2024 15:08
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@skudasov skudasov merged commit 84ab1ed into main Sep 9, 2024
40 of 41 checks passed
@skudasov skudasov deleted the feature/more-ports branch September 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skudasov skudasov skudasov approved these changes

@sebawo sebawo Awaiting requested review from sebawo sebawo is a code owner

@kalverra kalverra Awaiting requested review from kalverra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhuie19 @skudasov