Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag release #1122

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix tag release #1122

merged 2 commits into from
Sep 5, 2024

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Sep 5, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes enhance the CI workflow for publishing a test base image by dynamically modifying the image tag to exclude a specific directory prefix from the GitHub reference name. This ensures the image tag is correctly formatted and relevant to its use case.

What

  • .github/workflows/k8s-publish-test-base-image.yaml
    • Added a new step to strip "lib/" from github.ref_name before using it in the BASE_IMAGE_TAG environment variable. This ensures the base image tag does not include the "lib/" directory prefix, making the tag naming convention consistent and predictable.
    • Modified the env.BASE_IMAGE_TAG construction to use the modified github.ref_name without the "lib/" prefix, improving clarity and relevance of the Docker image tags.

@skudasov skudasov requested review from sebawo and a team as code owners September 5, 2024 18:41
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@skudasov skudasov merged commit 87d0eef into main Sep 5, 2024
57 of 59 checks passed
@skudasov skudasov deleted the fix-tag-release branch September 5, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants