Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make geth, eth2-common and besu charts compatible with staging cluster #1119

Merged
merged 13 commits into from
Sep 16, 2024
Merged

Make geth, eth2-common and besu charts compatible with staging cluster #1119

merged 13 commits into from
Sep 16, 2024

Conversation

scheibinger
Copy link
Contributor

@scheibinger scheibinger commented Sep 5, 2024 •
edited
Loading

  • Adjust geth-prysm, besu-prysm and eth-common charts to work with rootless pods in kubernetes.
    • Define security context
    • use 1000 user instead of root for running container commands
    • Switch to updated docker image with genesis generator
  • Upgrade dependencies to the latest versions

Required for CRIB-345

Testing

  • Tested both geth + prysm and besu + prysm on CRIB.
  • Starting fresh deployment worked fine, restarting geth pod worked fine. Restarting beacon chain node didn't work as per existing limitations.

@scheibinger scheibinger changed the title Make geth and eth2 charts compatible with staging cluster Make geth, eth2-common and besu charts compatible with staging cluster Sep 16, 2024
scheibinger
scheibinger commented Sep 16, 2024
View reviewed changes
lib/charts/besu-prysm/Chart.lock
digest: sha256:6bc7b0b10fab00cba405205673182004e440508efc06d51a80b6ddbf3f7300e1
generated: "2024-03-07T13:05:57.276874+01:00"
repository: file://../eth2-common
version: 0.5.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to run helm dependency update after eth2-common is already pushed to registry

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@scheibinger scheibinger marked this pull request as ready for review September 16, 2024 12:54
@scheibinger scheibinger requested review from sebawo and a team as code owners September 16, 2024 12:54
@scheibinger scheibinger merged commit 26f65fa into main Sep 16, 2024
48 checks passed
@scheibinger scheibinger deleted the crib-345/eth2 branch September 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofel Tofel Tofel approved these changes

@sebawo sebawo Awaiting requested review from sebawo sebawo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scheibinger @Tofel