Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interface for private ethereum network to use with new deployer #1107

Closed
wants to merge 8 commits into from

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 28, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

This change introduces a new interface and its implementation for configuring a private Ethereum network, enabling customization of the Ethereum version, execution layer, Docker network names, custom Docker images, and chain configuration. It ensures flexibility and extensibility in setting up private Ethereum networks for development or testing purposes.

What

  • config/private_ethereum_network.go
    • Added PrivateEthereumNetworkConfig interface: Defines methods for retrieving Ethereum version, execution layer, Docker network names, custom Docker images, and chain configuration.
    • Implemented PrivateEthereumNetworkConfig methods in EthereumNetworkConfig struct: Provides concrete definitions for the interface methods, allowing for the retrieval of configured values for a private Ethereum network setup.

@Tofel Tofel changed the title add interface fir private ethereum network to use with new deployer add interface for private ethereum network to use with new deployer Aug 29, 2024
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

@Tofel
Copy link
Contributor Author

Tofel commented Oct 23, 2024

no longer needed

@Tofel Tofel closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant