-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interface for private ethereum network to use with new deployer #1107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
changed the title
add interface fir private ethereum network to use with new deployer
add interface for private ethereum network to use with new deployer
Aug 29, 2024
Quality Gate failedFailed conditions |
no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
This change introduces a new interface and its implementation for configuring a private Ethereum network, enabling customization of the Ethereum version, execution layer, Docker network names, custom Docker images, and chain configuration. It ensures flexibility and extensibility in setting up private Ethereum networks for development or testing purposes.
What
PrivateEthereumNetworkConfig
interface: Defines methods for retrieving Ethereum version, execution layer, Docker network names, custom Docker images, and chain configuration.PrivateEthereumNetworkConfig
methods inEthereumNetworkConfig
struct: Provides concrete definitions for the interface methods, allowing for the retrieval of configured values for a private Ethereum network setup.