From f405c6645dd8b3a1173cd3ed52b40599297c11a2 Mon Sep 17 00:00:00 2001
From: Bartek Tofel <bartek.tofel@smartcontract.com>
Date: Mon, 23 Oct 2023 10:06:17 +0200
Subject: [PATCH] more debug to see which readiness probe is failing

---
 .github/workflows/env-e2e.yaml | 6 +++---
 env/client/client.go           | 4 +++-
 env/e2e/common/test_common.go  | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/env-e2e.yaml b/.github/workflows/env-e2e.yaml
index e2589c99a..a107906b5 100644
--- a/.github/workflows/env-e2e.yaml
+++ b/.github/workflows/env-e2e.yaml
@@ -37,10 +37,10 @@ jobs:
           AWS_ROLE_TO_ASSUME: ${{ secrets.QA_AWS_ROLE_TO_ASSUME }}
       - name: Base Image Built
         run: |
-          # shellcheck disable=SC2086
+          # shellcheck disable=SC2086,SC2006
           cat <<EOT >>$GITHUB_STEP_SUMMARY
-          ### chainlink image used for this test run :link: => ${{ env.CHAINLINK_VERSION }}
-          ### test-base-image image tag for this test run :ship: => ci.${{ github.sha }}
+          ### chainlink image tag used for this test run :link: => `${{ env.CHAINLINK_VERSION }}`
+          ### test-base-image image tag for this test run :ship: => `ci.${{ github.sha }}`
           EOT
       - name: Build Test Runner
         uses: smartcontractkit/chainlink-github-actions/docker/build-push@ce87f8986ca18336cc5015df75916c2ec0a7c4b3 # v2.1.2
diff --git a/env/client/client.go b/env/client/client.go
index e58c5f1e4..bb55e2634 100644
--- a/env/client/client.go
+++ b/env/client/client.go
@@ -285,7 +285,7 @@ func (m *K8sClient) WaitPodsReady(ns string, rcd *ReadyCheckData, expectedPodCou
 	for {
 		select {
 		case <-timeout.C:
-			return fmt.Errorf("waitcontainersready, no pods in %s with selector %s after timeout %s",
+			return fmt.Errorf("waitcontainersready, no pods in '%s' with selector '%s' after timeout '%s'",
 				ns, rcd.ReadinessProbeCheckSelector, rcd.Timeout)
 		case <-ticker.C:
 			podList, err := m.ListPods(ns, rcd.ReadinessProbeCheckSelector)
@@ -303,8 +303,10 @@ func (m *K8sClient) WaitPodsReady(ns string, rcd *ReadyCheckData, expectedPodCou
 			allReady := true
 			for _, pod := range podList.Items {
 				if pod.Status.Phase == "Succeeded" {
+					log.Debug().Str("Pod", pod.Name).Msg("Pod is in Succeeded state")
 					continue
 				} else if pod.Status.Phase != v1.PodRunning {
+					log.Debug().Str("Pod", pod.Name).Str("Phase", string(pod.Status.Phase)).Msg("Pod is not running")
 					allReady = false
 					break
 				}
diff --git a/env/e2e/common/test_common.go b/env/e2e/common/test_common.go
index d80c3e017..7c334d732 100644
--- a/env/e2e/common/test_common.go
+++ b/env/e2e/common/test_common.go
@@ -24,7 +24,7 @@ import (
 )
 
 const (
-	TestEnvType = "chainlink-testing-framework-test"
+	TestEnvType = "chainlink-testing-framework-env-test"
 )
 
 var (