Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple artifacts with classifiers? #62

Open
seancorfield opened this issue Jan 16, 2024 · 4 comments
Open

Multiple artifacts with classifiers? #62

seancorfield opened this issue Jan 16, 2024 · 4 comments

Comments

@seancorfield
Copy link

See clojure-doc/clojure-doc.github.io#68 and this Slack thread: https://clojurians.slack.com/archives/C0H28NMAS/p1705364966218609

Per Alex: multiple artifacts with different classifiers all share the same pom and usually they are uploaded as part of the same deployment (with normal maven deploy plugin).

Is this something that deps-deploy might want to support?

If not, is validating the JAR name (to be artifact-version.jar) or renaming it to that during uploading something that deps-deploy might want to handle (to avoid the issue in the thread above)?

@slipset
Copy link
Owner

slipset commented Jan 18, 2024

Initially, my thinking about deps-deploy was to do one thing, and one thing only - deploy your stuff to a repository.
In deps-deploy, I use depstar to produce the jar, and one could (perhaps) argue that the verification step might live there, or even as a separate thing in-between depstar and deps-deploy.

So in short, I think I'd rather not, but I don't have very strong feelings either way.

@seancorfield
Copy link
Author

Not sure what depstar has to do with anything here? I think you misunderstood what I'm asking here.

@slipset
Copy link
Owner

slipset commented Jan 19, 2024

I might very well have misunderstood. Reading over it again, it seems to me that you're asking for two things:

  1. Uploading multiple artifacts under different classifiers in one go, using the same pom - Yes I think that's something that deps-deploy should support.
  2. Validating the nam of or renaming the artifact (which was what I answered to above), no I don't think that's something deps-deploy should support.

I hope that I managed to understand you better on my second reading through?

@seancorfield
Copy link
Author

Alex says the Maven deploy plugin renames the JAR you give it to <artifact>(-<classifier>)?-<version>.jar which is what is required for Maven/Clojars etc to be able to server the artifact correctly so the validation/renaming question was intended to get parity in tooling support from deps-deploy.

The issue here is that if a user creates their JAR with a non-standard name, deps-deploy will happily upload it, but no one will be able to depend on it -- which is what happened in the referenced Slack thread.

The classifier/multiple artifacts question sort of falls out of that: if deps-deploy understands (and enforces) the artifact/classifier/version format, then it might be a reasonable enhancement to support multiple artifacts and classifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants