Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump typescript from 5.3.3 to 5.5.4 in /packages/web-api #2005

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2024

Bumps typescript from 5.3.3 to 5.5.4.

Release notes

Sourced from typescript's releases.

TypeScript 5.5.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

... (truncated)

Commits
  • c8a7d58 Bump version to 5.5.4 and LKG
  • c0ded04 🤖 Pick PR #58771 (Allow references to the global Symb...) into release-5.5 (#...
  • 5ba41e2 🤖 Pick PR #59208 (Write non-missing undefined on mapp...) into release-5.5 (#...
  • b075332 🤖 Pick PR #59337 (Allow declarationMap to be emitted ...) into release-5.5 (#...
  • 9dd6f91 Cherry-pick "Stop using latest Node in CI" to release-5.5 (#59348)
  • bf0ddaf 🤖 Pick PR #59070 (Delay the calculation of common sou...) into release-5.5 (#...
  • a44e2d9 🤖 Pick PR #59160 (Fixed crash on authored import type...) into release-5.5 (#...
  • f35206d 🤖 Pick PR #59325 (Don't skip markLinkedReferences on ...) into release-5.5 (#...
  • 1109550 Fix baselines on release-5.5 (#59330)
  • 8794318 🤖 Pick PR #59215 (Fix codefix crash on circular alias...) into release-5.5 (#...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 4, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/web-api/typescript-5.5.4 branch from df7d8a5 to e303937 Compare September 4, 2024 15:37
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.3 to 5.5.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.3.3...v5.5.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/packages/web-api/typescript-5.5.4 branch from e303937 to 2147bc9 Compare September 4, 2024 15:39
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (9bc20a1) to head (8f66dbf).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
- Coverage   90.26%   90.21%   -0.06%     
==========================================
  Files          34       34              
  Lines        7666     7672       +6     
  Branches      381      384       +3     
==========================================
+ Hits         6920     6921       +1     
- Misses        734      739       +5     
  Partials       12       12              
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 96.93% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.44% <100.00%> (-0.14%) ⬇️
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj
Copy link
Contributor

filmaj commented Sep 4, 2024

Going to hold off on this one for now as I have changes incoming that change the types a bit in web-api. Don't want to make too many changes all at once, and TypeScript is notorious for shipping breaking changes.

@WilliamBergamin
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@WilliamBergamin
Copy link
Contributor

@filmaj I think we can merge this now 🤔

@filmaj
Copy link
Contributor

filmaj commented Sep 5, 2024

I want to try one more thing: adding an integration test between these repos and bolt-js 😅
I am nervous changing TypeScript as it has unexpected downstream effects, especially for consumers using these packages in a transitive way (e.g. a developer app is built in typescript, but uses a different version of TS than these packages, and their app then uses bolt-js, which uses an again-different version of TS, which finally consumes these packages).

I will look at this PR once I have these integration tests in place!

@filmaj filmaj self-assigned this Sep 5, 2024
@filmaj
Copy link
Contributor

filmaj commented Sep 5, 2024

slackapi/bolt-js#2233 is a great example of where an integration test between types and bolt-js would have prevented the problem

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 9, 2024

A newer version of typescript exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants