Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we use ruff? #32

Open
marcieltorres opened this issue Feb 15, 2024 · 2 comments
Open

should we use ruff? #32

marcieltorres opened this issue Feb 15, 2024 · 2 comments
Labels
dependencies enhancement New feature or request

Comments

@marcieltorres
Copy link

marcieltorres commented Feb 15, 2024

Hello everyone,

Nowadays I'm using ruff for my projects and it's been amazing.

Some projects:
https://github.com/marcieltorres/safe-chat-slack-bot (it's a bot using Slack Bolt :) )
https://github.com/marcieltorres/python-boilerplate-project

So, what do you think about we add ruff on this template?

@zimeg zimeg added enhancement New feature or request dependencies labels Feb 23, 2024
@zimeg
Copy link
Member

zimeg commented Feb 23, 2024

Hey @marcieltorres 👋 Thanks for this suggestion! ruff seems like a really cool tool and we're interested in trying it on the Python templates. I totally believe that it's amazing.

Right now we might hold off on the replacement until the pycodestyle rules are implemented so certain lints are caught by ruff check - currently tracking this in astral-sh/ruff#2402 - but I think this'll be a great enhancement after that!

Talked with @WilliamBergamin about this too and great points were raised about consolidating the current .flake8 rules into the pyproject.toml which is always exciting! 🎉

@buhtz
Copy link

buhtz commented Feb 28, 2024

In my own projects I do combine several linters (in unit tests).
I do run ruff (with --preview flag) as the first because it is the fastest one. After that all the others (pycodestyle, pylint, codespell) are in the line. See my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants