Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] meta-object mixins #216

Merged
merged 2 commits into from
Aug 26, 2023
Merged

[ENH] meta-object mixins #216

merged 2 commits into from
Aug 26, 2023

Conversation

fkiraly
Copy link
Contributor

@fkiraly fkiraly commented Aug 25, 2023

This PR adds meta-object mixins - previously, the package provided only classes inheriting from BaseObject or BaseEstimator, which can create multiple inheritance conflicts if downstream needs to inherit from an abstract desceendant of BaseObject or BaseEstimator.

This is also more in line with the actual use cases in sktime and skpro.

@fkiraly fkiraly added the implementing framework Implementing core skbase framework label Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Merging #216 (2f64a37) into main (d840e75) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   83.59%   83.60%   +0.01%     
==========================================
  Files          43       43              
  Lines        2841     2843       +2     
==========================================
+ Hits         2375     2377       +2     
  Misses        466      466              
Files Changed Coverage Δ
skbase/base/__init__.py 100.00% <100.00%> (ø)
skbase/base/_meta.py 36.16% <100.00%> (+0.57%) ⬆️

@fkiraly fkiraly merged commit 027e0d7 into main Aug 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementing framework Implementing core skbase framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants