Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] switch CI macos runner to macos-latest #1633

Closed
wants to merge 1 commit into from
Closed

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 30, 2024

This switches the macos runner used in the CI to macos-latest, from macos-13.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (bde7169) to head (912e0a4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1633   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          32       32           
  Lines        4736     4736           
=======================================
  Hits         4263     4263           
  Misses        473      473           
Flag Coverage Δ
cpu 90.01% <ø> (ø)
pytest 90.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fkiraly pushed a commit that referenced this pull request Sep 13, 2024
…` failure on `macOS-latest` runner (#1648)

### Description

This PR handles the issue that may result when setting the device to `mps` if the torch version doesn't support `mps backend` 

Depends on #1633

I used `pytest.MonkeyPatch()` to disable the discovery of the `mps` accelerator. The tests run on CPU for `macOS-latest`

fixes #1596
@fkiraly
Copy link
Collaborator Author

fkiraly commented Sep 19, 2024

obsolete, as included in @fnhirwa's fix #1648

@fkiraly fkiraly closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants