Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove C++ OpenSSL Bindings #31

Open
sjudson opened this issue Feb 14, 2021 · 1 comment
Open

Remove C++ OpenSSL Bindings #31

sjudson opened this issue Feb 14, 2021 · 1 comment

Comments

@sjudson
Copy link
Owner

sjudson commented Feb 14, 2021

At the moment, the extcrypto.cc script [0] is used to provide two cryptographic functionalities: (i) generating RSA key material; and (ii) loading RSA key material stored in the .pem format.

As of Node 11, this functionality is available in the builtin crypto module, the former introduced in v10.12.0 [1] and the latter in v11.16.0[2]. As of May 1, 2021, Node v10 will no longer be supported [3]. As such, at that time the extcrypto module should be removed (as well as the dependency on nan) and the builtin functionalities used instead.

[0] https://github.com/sjudson/paseto.js/blob/master/extcrypto/extcrypto.cc
[1] https://nodejs.org/api/crypto.html#crypto_crypto_generatekeypair_type_options_callback
[2] https://nodejs.org/api/crypto.html#crypto_crypto_createprivatekey_key
[3] https://nodejs.org/en/about/releases/

@sjudson
Copy link
Owner Author

sjudson commented Feb 14, 2021

(created this issue mostly as a note to self, but if anyone has any comments/wants to open a PR they are more than welcome)

@sjudson sjudson mentioned this issue Mar 15, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant