-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk cache hit is not recorded in the HAR file #947
Comments
Hi @gogo9th sorry I missed this issue.
This was discussed a couple of years ago in the issues but I don't remember the outcome. Let me have a look early the coming week.
Yes you can skip the installation of Chromedriver set process.env.CHROMEDRIVER_SKIP_DOWNLOAD when you install, see https://github.com/sitespeedio/chromedriver Best |
I've added an example in the docs on how to skip installing: It's the same way if you use Browsertime. |
Hi @gogo9th do you use Chrome or Firefox? For Firefox we used to strip out those cache hits because of an upstream bug in the Firefox/Har exporter where they wasn't marked as cache hits firebug/har-export-trigger#36 - but now we use the new HAR Exporter and I need to investigate how that works, I don't remember. For Chrome its configurable but we have hidden that configuration (to include the cache hits), let me add that so at least you as a user can choose. |
Hi, thanks very much for taking care of the issue of disk hit recordings and chromdriver skipping. About the chromedriver skipping, the issue was not only non installing chromedriver, but making browsertime run without using chromedriver. Currently if I don't install chromedriver as shown in your example webpage, browsertime doesn't run properly. But I thought chromedriver would be needed only for computing speed index (not necessary for computing page loadtime), so I was wondering if it's possible to let browsertime run without chromedriver and without speedindex computation.. |
Hi, Chromedriver drives Chrome (see http://chromedriver.chromium.org), so if you skip it you cannot use Chrome but you can run Firefox (for example if you are on a ARM setup). To collect Visual Metrics we use https://github.com/WPO-Foundation/visualmetrics. By default using npm Visual metrics isn't used, you need to enable it with Best |
Hi Peter, thanks for your clarification. Meanwhile, I found another potential issue that doesn't work as I expect: node ../node_modules/browsertime/bin/browsertime.js --chrome.includeResponseBodies all -n 1 https://www.google.com ... After running this command, the HAR file doesn't print any contents of downloaded objects under ['response']['content']['text']. But if I change "all" to "html", the HAR file contains only html contents. So I think the "all" option is not properly working. |
Hi @gogo9th did you see f you got a redirect for https://www.google.com ? I tried it a couple of days ago but then it worked for me. Did you get any error log? If we try to get the HTML and do not find any matching responses, we log. Best |
Hi Peter, If I run the following: node node_modules/browsertime/bin/browsertime.js --chrome.includeResponseBodies all -n 1 https://www.google.com I get the following HAR output, which doesn't include any "text" field for any URLs: :Desktop/expose_runner2$ node node_modules/browsertime/bin/browsertime.js --chrome.includeResponseBodies all -n 1 https://www.google.com { |
Hi Peter, I wonder if you have any good news about having brwosertime record disk hits (and making the "--chrome.includeResponseBodies all" option work properly)... |
I also wonder if this is unfixable by any chance.. |
Hi @gogo9th sorry I forgot about this issue. I tried to turn it on in Chrome-har but it seems that all metrics aren't correct at the moment when we get them from disk cache. In this example all responses except the first one is from disk: Could be that Perf cascade that we use to render the waterfall needs to show that responses are from disk (I think we miss that). When that these two is fixed I think we can make it configurable in Browsertime. |
Hi Peter, thanks very much for your update! |
Hi Peter, I wonder if you have had any luck in this issue.. |
Hi Peter, Just enquiring whether this issue would be fixed with the new Browsertime? Regards, |
No I haven't worked at this. |
So ... I'm thinking that since there gone a couple years and nothing has happened: if you have this issue I would try with the latest HAR for Firefox by enabling |
Hi,
I am building an efficient web proxy and I need to record how many URLs are hit from the disk or memory cache from inside the browser. However, browsertime seems to omit those URLs that are disk/memory-hit. I wonder if you could change the HAR file format to include the disk/memory hit URLs as well...
Another issue is that I try to run browsertime from a Ubuntu Emulator (Linux on Dex) but browsertime doesn't run on an older version of chromium that does not have ARM-compatible chromedriver. I wonder if there's any way for us to run browsertime without requiring chromedriver (e.g., exclude speed index computation).
Thanks a lot for your help.
The text was updated successfully, but these errors were encountered: