Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTP event payload type can be set incorrectly when sending DTMF on an incoming call #1164

Closed
CNH01 opened this issue Aug 19, 2024 · 1 comment

Comments

@CNH01
Copy link
Contributor

CNH01 commented Aug 19, 2024

Suggested PR:
#1165

Scenario:

  • SIP transport receives an INVITE request with SDP containing the capability 96 telephone-event 0-15
  • Invite is accepted (by creating a SIPUserAgent and calling AcceptCall(SIPRequest inviteRequest))

Result:
The SIPUserAgent's media session's local track's capabilities are changed to support
96 telephone-event 0-15
rather than
101 telephone-event 0-16

So the SDP in the 200 OK when answering the call contains 96 telephone-event 0-15.

This becomes an issue when calling SendDtmf(byte tone) on the SIPUserAgent, as this calls SendDtmf(byte key, CancellationToken ct) on the AudioStream which, in turn, defaults to using 101 telephone-event 0-16 (RTPSession.DTMF_EVENT_PAYLOAD_ID).

So we end up sending DTMF with payload type 101, despite advertising that we will send payload type 96 when answering the call.

@sipsorcery
Copy link
Member

#1165 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants