Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI automation is overwriting the most recent release on PR merge #571

Open
aukeman opened this issue Oct 11, 2024 · 1 comment
Open

CI automation is overwriting the most recent release on PR merge #571

aukeman opened this issue Oct 11, 2024 · 1 comment

Comments

@aukeman
Copy link
Contributor

aukeman commented Oct 11, 2024

It appears that the github actions that fire on PR merges to master are building, packaging, and overwriting the most recent release based on the latest commit to the master branch. The result is that the binaries and and package files in the release are no longer based on the tagged commit indicated by the release name.

cf. the actions run upon merge of #569:

The release page for 1.5.3 shows that the release artifacts are far more recent than the tagged commit, and the release artifact checksums have been modified since last week.

I believe the issue is that the Build Packages, Archive Frontend, and Upload Release steps are being run on merges to master when perhaps it would be more appropriate for them to run only when github.even_name == 'release' ?

Copy link

Your report is appreciated. Please star this repository to motivate its developers! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant