Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is EquelleRuntimeCPU::boundaryFaces() so complex? #22

Open
johanseland opened this issue Apr 9, 2014 · 0 comments
Open

Why is EquelleRuntimeCPU::boundaryFaces() so complex? #22

johanseland opened this issue Apr 9, 2014 · 0 comments
Labels

Comments

@johanseland
Copy link
Contributor

The implemention of EquelleRuntimeCPU::boundaryFaces() is dependent of the internals of Opm::HelperOps and is impossible to adapt to the separataion of inner and outer boundaries. It's sole benefit seems to be that it knows in advance the number of boundary-faces at the cost of a while-loop nested inside a for-loop traversing over all the faces.

I have made a new implementation in RuntimeMPI that simply checks the face_cells flag for boundary::outer, much like EquelleRuntimeCPU::boundaryCells) which is work with inner and outer boundaries.

If this implementation is moved into EquelleRuntimeCPU instead, then RuntimeMPI can simply forward it call an we avoid having two implementations of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant