SSH tunnel #93
Open
SSH tunnel #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_dbs config property
and readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I find it really convenient for the tap to open an SSH tunnel during the connection, and close it afterwards. The alternative is to have some out-of-band process maintaining the tunnel. We've been using this in production for a while.
This PR also includes a change to add a config property
default_replication_key, similar in purpose to the existingdefault_replication_method. I merged them both together. If both of these are good features, I'd prefer to avoid splitting out the code change into separate PRs.Also updated the readme with documentation of the configuration properties that I understand.
QA steps
Risks
Rollback steps