Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 6 Language Mode #180

Open
dehlen opened this issue Jul 15, 2024 · 2 comments
Open

Swift 6 Language Mode #180

dehlen opened this issue Jul 15, 2024 · 2 comments

Comments

@dehlen
Copy link

dehlen commented Jul 15, 2024

First of all thanks for the library and the ongoing maintenance.

I am currently looking at the Swift 6 Language mode. I recognise there a ways to import this library without any issue even when using Swift 6 Language mode. However when building the package itself I found a few errors are thrown. Any plan to lift this packages language mode to 6 and to fix those errors?

Kind regards,
David

@sindresorhus
Copy link
Owner

I just tried building the example app here with Swift 6 mode and I get no errors or warnings from the KeyboardShortcuts package.

I don't plan to look into full Swift 6 mode in this package at the earliest after Xcode 16 final is out (way too many concurrency bugs in Swift 6 at the moment). But you should be able to import this package fine in a Swift 6 project even though this package is not Swift 6.

@dehlen
Copy link
Author

dehlen commented Jul 22, 2024

Yes as stated above the package works just fine even in a Swift 6 app which depends on this package. My point was rather when adding swiftLanguageVersions: [.version("6")] to the package manifest and building the package directly it encounters various compiler errors. Of course since one can use the package just fine and Xcode 16 isn't even officially released I recognise the fact that this has no priority. But I think it would be nice to have a look at those compiler warnings and fix/or silence them when appropriate once Xcode 16 is released. Feel free to either close due to the timeframe or keep it open as a reminder to have a look at this at a later point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants