Fix consistently failing test: Selector with a wait #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you forgot to include the |
On moderately slow networks, the "selector with a wait" test fails.
This commit replaces the `--wait 2000` argument with `--wait-for "!!document.querySelector('section.secondary')"`.
Fixes simonw#134
On moderately slow networks, the "selector with a wait" test fails. There is already a --wait-for test, so replacing the --wait test with --wait-for was a bad idea. This change reuses the --wait-for test's HTML with a delayed div instead. This way --wait with --selector is still tested. Fixes simonw#134
nielthiart
force-pushed
the
fix-test-wait-selector
branch
from
6e1bb3d
to
641ba60
Compare
Maybe having a unique name for each test will reduce ambiguity when discussing tests later on. Ref simonw#134
The |
|
Thanks for considering this PR. I realised now that I made a different mistake — I removed the original owlsnearme.com test completely, which was not my intention. This commit undoes that. Hopefully, that will get squashed away on merge, but please let me know if I should squash everything to clean this small change up. Taken as a whole, this update should now:
This way we still test timed waiting, just not for remote pages. |
|
Thanks very much for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On moderately slow networks, the "selector with a wait" test fails.
This commit replaces the--wait 2000argument with--wait-for "!!document.querySelector('section.secondary')".Edit: Reuses the --wait-for test's HTML with a delayed div.
Fixes #134
📚 Documentation preview 📚: https://shot-scraper--135.org.readthedocs.build/en/135/