transaction is already closed and cannot be used anymore

[sachin-dahal]

I've been into this issue and tried to fix it but couldn't get relevant solutions.
these are different functions called one after another and both have transaction on their body and maybe in this particular use case, I've encountered this issue.

can anyone help me to solve this issue?

---

(r) async {
   //* I've used a transaction here that consists multiple
   //* db operations with await keyword
   _appDatabase.transaction(() async { ... 
});
    } else
      allDataSyncedNumbers.value = _dependentDataCount;
    setLoading(false);
  }
}

Future syncAllRelatedData(int businessID) async {
    RxInt sendReq = 0.obs;
    setLoading();
      Map<String, List> _postData = Map<String, List>();

      //! Issue displays over this block
      //! Unhandled Exception: Bad state: This database or transaction runner has already been closed and may not be used anymore.
      //! If this is happening in a transaction, you might be using the transaction without awaiting every statement in it.
      List<SalesModel> allSyncableSalesModel =
          await _appDatabase.salesDao.getSyncableSales();

      List<SalesReturnModel> allSyncableSalesReturnModel =
          await _appDatabase.salesReturnsDao.getSyncableSalesReturn();
...
...

Error

[ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Bad state: This database or transaction runner has already been closed and may not be used anymore.

If this is happening in a transaction, you might be using the transaction without awaiting every statement in it.

E/flutter (31036): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: Bad state: This database or transaction runner has already been closed and may not be used
E/flutter (31036): anymore.
E/flutter (31036):
E/flutter (31036): If this is happening in a transaction, you might be using the transaction
E/flutter (31036): without awaiting every statement in it.
E/flutter (31036): #0      _BaseExecutor._debugCheckIsOpen
package:drift/…/helpers/engines.dart:36
E/flutter (31036): #1      _BaseExecutor.runSelect.<anonymous closure>
package:drift/…/helpers/engines.dart:69
E/flutter (31036): #2      _BaseExecutor._synchronized.<anonymous closure>
package:drift/…/helpers/engines.dart:51
E/flutter (31036): #3      new Future.sync (dart:async/future.dart:296:31)
E/flutter (31036): #4      Lock.synchronized.callBlockAndComplete
package:drift/…/utils/synchronized.dart:17
E/flutter (31036): #5      Lock.synchronized.<anonymous closure>
package:drift/…/utils/synchronized.dart:21
E/flutter (31036): #6      _rootRunUnary (dart:async/zone.dart:1434:47)
E/flutter (31036): #7      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
E/flutter (31036): <asynchronous suspension>
E/flutter (31036): #8      _BaseExecutor.runSelect
package:drift/…/helpers/engines.dart:68
E/flutter (31036): <asynchronous suspension>
E/flutter (31036): #9      JoinedSelectStatement._getRaw.<anonymous closure>
package:drift/…/select/select_with_join.dart:223
E/flutter (31036): <asynchronous suspension>
E/flutter (31036): #10     JoinedSelectStatement.get
package:drift/…/select/select_with_join.dart:216

[North101]

Are you awaiting all futures in the transaction? If you don't the transaction will close while the database is being updated.

[sachin-dahal]

yes, I've awaited all the futures but yet there is an issue

[North101]

I think you'll need to post more code. It might be that you missed one or in another function you're call you're not awaiting a future.

[sachin-dahal]

Here it is, https://gist.github.com/sachin-dahal/3591f27b8a96efb8a2c7e298d92b3ec5
please view it once

[sachin-dahal]

Here is a gist to view more code: https://gist.github.com/sachin-dahal/3591f27b8a96efb8a2c7e298d92b3ec5

[North101]

The thing that stands out to me is:

      result.fold(
        (l) {
          ...
        },
        (r) async {
            _appDatabase.transaction(() async {

You should probably return or await _appDatabase.transaction here, but the use of fold here is kind of odd. I would restructure your code to remove it. e.g.

    if (_postData.isNotEmpty) {
      setFailure();
      final result =
          await _dataBackupRepo.syncDependentData(_postData, businessID);
      if (result.isNotEmpty) {
          if (Get.isDialogOpen!) Get.back();
          kSnackbar(title: 'error'.tr, message: l.message);
          setFailure(null);

          await _appDatabase.transaction(() async {
            for (final r in result) {
              if (allSyncableItems.isNotEmpty) {
...

[sachin-dahal]

I've used fold here to handle the response from the API. I don't think this is a cause for our issue.
As per @simolus3 , not awaiting transaction(...) is mildly suspicious but that shouldn't cause the problem. I've also tried doing so but end up with the same issue.

[simolus3]

As we discussed privately, the problem here turned out to be a broken Stream implementation in package:get that doesn't respect zones. I've sent @codersamir a workaround in Gitter.

[sachin-dahal]

also, the problem is solved, and thank you for the help @simolus3 .