Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or remove loading LinkModal via injector #202

Closed
emteknetnz opened this issue Feb 5, 2024 · 1 comment
Closed

Fix or remove loading LinkModal via injector #202

emteknetnz opened this issue Feb 5, 2024 · 1 comment
Assignees
@emteknetnz
Labels
type/bug

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Feb 5, 2024 •
edited
Loading

The use of loadComponent(LinkModal.${handlerName}); in LinkModalContainer.js caused this hard to diagnose issue #85 (comment)

Either fix this so that it doesn't cause re-rendering issue in elemental, or remove it and use <LinkModal> directly
@emteknetnz emteknetnz mentioned this issue Feb 5, 2024
Merged
@emteknetnz
Copy link
Member Author

Going with this approach instead - no need to make this a reusable hook as was discussed in slack as there are no other function components in sink that use loadComponent()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxime-rainville @emteknetnz