Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top page integration with Fluent module #1258

Open
2 tasks done
mfendeksilverstripe opened this issue Sep 26, 2024 · 1 comment
Open
2 tasks done

Top page integration with Fluent module #1258

mfendeksilverstripe opened this issue Sep 26, 2024 · 1 comment

Comments

@mfendeksilverstripe
Copy link
Contributor

Module version(s) affected

5.2.4

Description

Top page feature can support integration with the Fluent module but there are some gaps:

  • docs are outdates and refer to extensions setup that's no longer there
  • we should provide out of the box integration as it's easy to do

How to reproduce

  • installing Fluent module is needed
  • Top page feature doesn't auto integrate with the module
  • what we want to see is the TopPage\DataExtension to be replaced with TopPage\FluentExtension automatically
  • this does not happen and it's also necessary to use Injector to do this replacement as the TopPage\DataExtensionis hard coded in theBaseElementandElementalAreaclasses instead of using named keysyml` configuration format.

Possible Solution

  • replace hard coded extensions with configurable yml format using named keys
  • provide auto detection in which extension is used

Additional Context

No response

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@mfendeksilverstripe
Copy link
Contributor Author

Fixed in #1259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants