Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published campaigns can be deleted #54

Open
flamerohr opened this issue Sep 5, 2017 · 6 comments
Open

Published campaigns can be deleted #54

flamerohr opened this issue Sep 5, 2017 · 6 comments

Comments

@flamerohr
Copy link
Contributor

With all campaigns showing now, it is possible to delete campaigns which has been published.
This means that users could be deleting historical data quite easily.

We should restrict deleting to open campaigns which have not been published. And have a filter available to hide already published campaigns.

Luckily the campaigns are sorted by open campaigns first.

@chillu
Copy link
Member

chillu commented Nov 7, 2017

@clarkepaul @newleeland Do you agree with this assessment?

@clarkepaul
Copy link

Yup sure do :)

@phalkunz phalkunz self-assigned this Nov 30, 2017
@newleeland
Copy link

By removing delete, we'll need to provide some sort of explanation of why there's no delete option on some campaigns, while others do!

Having said that, I don' think we should remove the delete button by default. As it will clutter the campaigns section with many campaigns. rather have a warning on delete. Rather than dictate what the user can do.

@chillu
Copy link
Member

chillu commented Dec 1, 2017

Campaigns are part of an audit record once they're published, so authors shouldn't be able to delete them. We need to create a UI which reduces the noise of having potentially hundreds of published campaigns in the system. We could split out list views to "open" vs. "recently published", with a "view more" option? Then underneath the "recently published" list, you could have a note about why they can't be deleted.

@tractorcow
Copy link

Should be easy... hide published campaigns by default, set canDelete() to false for these records.

@clarkepaul
Copy link

Deleting a campaign shouldn't happen but we wanted to see how many campaigns (if any) people usually have open because if they only have 1 then showing the history of published campaigns would make sense but if sites have 15 campaigns on the go then we could look at splitting them apart.

@phalkunz phalkunz removed their assignment Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants