Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CampaignAdmin class refactoring opportunities #282

Open
5 tasks
sabina-talipova opened this issue Oct 19, 2023 · 0 comments
Open
5 tasks

CampaignAdmin class refactoring opportunities #282

sabina-talipova opened this issue Oct 19, 2023 · 0 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

Description

  • CampaignAdmin::getCampaignEditForm:
    • Use GridFieldDetailForm once it can handle structured data and form schemas
    • move to FormBuilder
  • CampaignAdmin::getCampaignCreateForm:
    • move to FormBuilder

See:
This was referenced Oct 19, 2023
Merged
Closed
@GuySartorelli GuySartorelli changed the title TODO: CampaignAdmin class improvememnts CampaignAdmin class refactoring opportunities Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sabina-talipova