Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files added to page already in campaign don't get added to campaign #185

Open
maxime-rainville opened this issue Nov 7, 2020 · 3 comments

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Nov 7, 2020

Steps

  • Create a campaign
  • Create a page
  • Add an image to the page (File status is irrelevant)
  • Save
  • Add page to campaign
  • Add a different image to the page and Save
  • Navigate to campaign admin and look up the object associated to the campaign

Expected: Both images are associated with the campaign
Actual: Only the first image is associated to the campaign

https://youtu.be/CxrrV524Aik

Possible duplicate of #163.

@maxime-rainville
Copy link
Contributor Author

^ @silverstripeux I think this behaviour is strange and counter intuitive.

@brynwhyman
Copy link

What happens if there's a force-refresh? That may show the second image?

And does the second image still publish?

Plus, @Cheddam is going to link a related issue to this.

@maxime-rainville
Copy link
Contributor Author

Here's an extra video where I go an extra step and try to actually publish my campaign.

https://youtu.be/oBl27a37khs

Looks like campaign admin realises there's stuff missing and silently refuses to publish the campaign. But it doesn't tell you anything.

If you refresh, the missing image has been added to the campaign and you can then publish in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants