Squished TinyMCE Editor

[zanderwar]

[robbieaverill]

Hey @zanderwar, which version of SS4 are you using? I think this field is supposed to be shorter because it's a summary field, do you think it should be larger?

[zanderwar]

RC1 - It should fill the space imho, it looks very... dodgy otherwise

[zanderwar]

If you add the label instead of omitting it, it should make it look better, and give top padding

In hindsight, this isn't actually an "issue", albeit only aesthetically

[robbieaverill]

The reason the gaps are there is that the left is for a field label and right is for right title. I agree with you here personally, but perhaps this should be a framework or admin issue?

[robbieaverill]

Ok, would you be keen to submit a PR for that and we can see how it looks?

[zanderwar]

I believe there might be a

HtmlEditorField::create('Summary', '');

somewhere, might be worth adding the label in

[zanderwar]

God that felt good. I'll PR if this is approved here, otherwise can't fathom wasting the time :P

[robbieaverill]

Cc @clarkepaul

[clarkepaul]

Looks good this PR is a definite improvement. Yeah right side space is for the "extra label" which I hope to put into a (?) tooltip so we have more space. Normally TinyMCE areas align far left with the label above on pages but I guess that is custom styles.

Are these changes only applied when nesting in the accordion/expandable areas or general?

[zanderwar]

@clarkepaul The right side label is ugly no matter what, it was great when it used to appear under the field. I would absolutely love the tooltip approach.

[robbieaverill]

We should check that this issue still exists with silverstripe/silverstripe-admin#446 merge into core

[robbieaverill]

Issue still exists