Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LeftAndMain abstract and other small refactoring in this class #1763

Open
GuySartorelli opened this issue May 30, 2024 · 0 comments
Open

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented May 30, 2024

There's no good reason to instantiate LeftAndMain. It should be abstract.

Related

Acceptance criteria

  • LeftAndMain is made abstract
  • Anything that requires instantiating LeftAndMain is refactored to use a concrete class instead.
  • A new abstract getModelClass() method is created
  • The tree_class configuration property is removed - anything that used this configuration is updated to call getModelClass() instead.
  • Methods which used that config are updated according to the "tree_class config" section in this comment unless doing so causes unforeseen problems
  • Recommendations in the "Additional recommendations" section in this comment are applied unless doing so causes unforeseen problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants