From 1f2d69e2081bdb1c909df854bd15d1c87464d5dc Mon Sep 17 00:00:00 2001 From: Mohamed Alsharaf Date: Tue, 20 Aug 2024 17:51:31 +1200 Subject: [PATCH] Fix TinyMCE edit link when link contains html --- client/src/legacy/TinyMCE_sslink.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/client/src/legacy/TinyMCE_sslink.js b/client/src/legacy/TinyMCE_sslink.js index 374311cb0..605ff9cee 100644 --- a/client/src/legacy/TinyMCE_sslink.js +++ b/client/src/legacy/TinyMCE_sslink.js @@ -35,7 +35,16 @@ const plugin = { // Callback for opening the edit link dialog form function openLinkDialog() { - const node = tinymce.activeEditor.selection.getNode(); + // Find "a" node, issue https://github.com/silverstripe/silverstripe-cms/issues/2439 + let node = tinymce.activeEditor.selection.getNode(); + if (node.nodeName !== 'A') { + let count = 0; + while (count < 10 && node.parentNode && node.nodeName !== 'A') { + node = node.parentNode; + count += 1; + } + } + const href = node.getAttribute('href'); if (href) {