DOC Changing ClassName from Enum to Varchar #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/varchar-classname
branch
5 times, most recently
from
193592f
to
88c7917
Compare
GuySartorelli
requested changes
Sep 5, 2024
emteknetnz
force-pushed
the
pulls/5/varchar-classname
branch
6 times, most recently
from
96a523e
to
d980a50
Compare
|
LGTM but needs to be rebased |
GuySartorelli
requested changes
Sep 9, 2024
emteknetnz
force-pushed
the
pulls/5/varchar-classname
branch
2 times, most recently
from
71b7748
to
322c094
Compare
GuySartorelli
requested changes
Sep 10, 2024
emteknetnz
force-pushed
the
pulls/5/varchar-classname
branch
from
322c094
to
98e36cb
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11358