Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC CMS JSON API's #445

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 24, 2024

Issue #422

Note I've made a lot of mentions to jsonSuccess() which currently does not exist and is added in this PR

@emteknetnz emteknetnz force-pushed the pulls/5.1/cms-only-controllers branch 5 times, most recently from bd37dc4 to 4d736a4 Compare January 24, 2024 22:28
@emteknetnz emteknetnz marked this pull request as ready for review January 24, 2024 22:29
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5.1/cms-only-controllers branch from 4d736a4 to de45db1 Compare January 25, 2024 04:01
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5.1/cms-only-controllers branch from de45db1 to fcfc123 Compare January 29, 2024 03:36
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small bits to tidy up

en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/02_Controllers/07_CMS_JSON_APIs.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5.1/cms-only-controllers branch from fcfc123 to f5a095a Compare January 29, 2024 04:04
@emteknetnz emteknetnz changed the base branch from 5 to 5.1 January 29, 2024 04:05
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli changed the base branch from 5.1 to 5 January 29, 2024 04:15
@GuySartorelli GuySartorelli merged commit a648bbb into silverstripe:5 Jan 29, 2024
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.1/cms-only-controllers branch January 29, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants