Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote file dialogue doesn't respect custom dimensions #160

Open
phptek opened this issue Oct 25, 2018 · 1 comment
Open

Remote file dialogue doesn't respect custom dimensions #160

phptek opened this issue Oct 25, 2018 · 1 comment

Comments

@phptek
Copy link

phptek commented Oct 25, 2018

Versions

PHP 7.1.23

#> composer info | grep cwp/
cwp/cwp                                                  2.1.1              CWP features module. We strongly recommend using it for all new sites. Future features will be delivered here.
cwp/cwp-core                                             2.1.1              CWP basic compatibility module. Use for migrations.
cwp/cwp-pdfexport                                        1.0.1              Add PDF export capability for pages in CWP
cwp/cwp-recipe-cms                                       2.1.1              CWP CMS requirements recipe
cwp/cwp-recipe-core                                      2.1.1              CWP core requirements recipe
cwp/cwp-recipe-search                                    2.1.1              CWP search requirements recipe
cwp/cwp-search                                           1.0.0              CWP fulltextsearch integration module

Issue

Using the "Insert Media via URL" TinyMCE feature, and fetching a remote image, or video; no matter what I put into the "Width" and "Height" user-input form fields, the image's (or video's placeholder image) original dimensions are maintained (as per login in the embed/embed dependency) and my custom ones overridden or ignored.

There is probably a very simple way to fix this in some React component...somewhere.

@phptek
Copy link
Author

phptek commented Oct 25, 2018

More info: The moment I type a key while focused in the "Width" field for example, I see a JS TypeError in my console:

TypeError: t.target is undefined[Learn More] from bundle.js in silverstripe/asset-admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants