Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually ensure all module have merge-up.yml and dispatch-ci.yml #249

Closed
emteknetnz opened this issue May 15, 2024 · 2 comments
Closed

Manually ensure all module have merge-up.yml and dispatch-ci.yml #249

emteknetnz opened this issue May 15, 2024 · 2 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented May 15, 2024

Module standardiser is being run on all supported repos in this issue #242

However, because the default branch is incorrect on some supported modules that are not on the silverstripe account, they will only get their CMS 5 branches updated but not the default branch where the github actions are run

Recommend that you write a script that goes though all the supported modules, and then make a github api call to determine to default branch, then read contents of the default branch to see if the 2x workflow files exist, and then manually create PRs to add them to the default branches

Script used

Notes

  • PRs are copied the merge-up.yml + dispatch.yml from the CMS 5 branch to the default branch
  • CI is likely to fail on all PRs because the default branches are out of date

PRs

@GuySartorelli
Copy link
Member

Looks like the only items missed by this are recipes (which we explicitly DO NOT want to have mergeups, so that's good) and things that aren't supported for CMS 5... which is a grey area so I'll leave those be.

@GuySartorelli GuySartorelli self-assigned this May 22, 2024
@GuySartorelli
Copy link
Member

PRs merged. I've run merge-ups, which mostly failed due to conflicts but there's a separate card open to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants