Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade hotchocolate to 14 #1167

Merged
merged 5 commits into from
Oct 31, 2024
Merged

upgrade hotchocolate to 14 #1167

merged 5 commits into from
Oct 31, 2024

Conversation

hahn-kev
Copy link
Collaborator

this may or may not fix the race condition in #1156

@hahn-kev hahn-kev requested a review from myieye October 28, 2024 03:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c895334. ± Comparison against base commit a84c509.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

C# Unit Tests

75 tests  ±0   75 ✅ ±0   5s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c895334. ± Comparison against base commit a84c509.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev marked this pull request as ready for review October 30, 2024 08:00
myieye
myieye approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@myieye Graphite App
Copy link
Contributor

myieye commented Oct 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hahn-kev and the rest of your teammates on Graphite Graphite

@myieye myieye mentioned this pull request Oct 30, 2024
Closed
@myieye Graphite App
Copy link
Contributor

myieye commented Oct 30, 2024 •
edited
Loading

Merge activity

  • Oct 30, 9:03 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Oct 30, 9:21 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.

@myieye myieye merged commit e83930d into develop Oct 31, 2024
14 checks passed
@myieye myieye deleted the bug/ef-hc-middleware-race branch October 31, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye myieye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hahn-kev @myieye