Don't throw if added org member already exists

sillsdev · Jun 10, 2024 · f47d4df · f47d4df
1 parent ed45fe8
commit f47d4df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/backend/LexBoxApi/GraphQL/OrgMutations.cs b/backend/LexBoxApi/GraphQL/OrgMutations.cs
@@ -39,7 +39,6 @@ public async Task<IQueryable<Organization>> CreateOrganization(string name,
 
     [Error<DbError>]
     [Error<NotFoundException>]
-    [Error<AlreadyExistsException>]
     [UseMutationConvention]
     [UseFirstOrDefault]
     [UseProjection]
@@ -57,7 +56,8 @@ public async Task<IQueryable<Organization>> AcquireProject(
 
         if (await dbContext.OrgProjects.AnyAsync(op => op.OrgId == orgId && op.ProjectId == projectId))
         {
-            throw new AlreadyExistsException("Organization already owns this project");
+            // No error since we're already in desired state; just return early
+            return dbContext.Orgs.Where(o => o.Id == orgId);
         }
         await dbContext.OrgProjects.AddAsync(new OrgProjects { OrgId = orgId, ProjectId = projectId });
         await dbContext.SaveChangesAsync();

diff --git a/frontend/schema.graphql b/frontend/schema.graphql
@@ -381,7 +381,7 @@ type UsersCollectionSegment {
   totalCount: Int!
 }
 
-union AcquireProjectError = DbError | NotFoundError | AlreadyExistsError
+union AcquireProjectError = DbError | NotFoundError
 
 union AddProjectMemberError = NotFoundError | DbError | ProjectMembersMustBeVerified | ProjectMembersMustBeVerifiedForRole | ProjectMemberInvitedByEmail | InvalidEmailError | AlreadyExistsError