Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.1.3 -- log API Secret error, increase log retention #152

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Release 3.1.3 -- log API Secret error, increase log retention #152

merged 6 commits into from
Sep 3, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Aug 28, 2024

Added

  • If the API Secret is NOT valid, log its first and last few characters
    • This should help us confirm whether, for instance, and equals sign has been dropped from the end of the string.

Changed

  • Increased log retention to 60 days (ITSE-999 Increase Cloudwatch Log retention)

forevermatt and others added 4 commits May 6, 2024 16:03
@forevermatt
If the API Secret is NOT valid, log its first and last few characters
92fab81 
This should help us confirm whether, for instance, and equals sign has
been dropped from the end of the string.
@forevermatt
Merge pull request #151 from silinternational/feature/log-redacted-ap…
5347736 
…iSecret-if-incorrect

If the API Secret is NOT valid, log its first and last few characters
@briskt
update docker compose
d9766c4
@briskt
increase log retention to 60 days
ead06a1
@briskt briskt requested a review from a team August 28, 2024 08:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt changed the title Release 3.1.3 Release 3.1.3 -- log API Secret error, increase log retention Aug 30, 2024
hobbitronics
hobbitronics approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@briskt briskt merged commit 544cec1 into main Sep 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @hobbitronics @forevermatt