Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom trusted root target path #1608

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

codysoyland
Copy link
Member

Summary

This PR adds support to customize the trusted root target filename in the TrustRoot CRD.

Test data has been regenerated, so the expiration has been extended from 2024-09-22 to 2025-03-02.

Fixes #1607

Release Note

Documentation

@hectorj2f
Copy link
Collaborator

LGTM although there are few tests failing.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (50ef092) to head (e543395).
Report is 187 commits behind head on main.

Files with missing lines Patch % Lines
hack/gentestdata/gentestdata.go 0.00% 7 Missing ⚠️
pkg/reconciler/trustroot/trustroot.go 46.15% 6 Missing and 1 partial ⚠️
cmd/tester/trustroot.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1608       +/-   ##
===========================================
- Coverage   52.92%   42.25%   -10.67%     
===========================================
  Files          44      121       +77     
  Lines        3979     7182     +3203     
===========================================
+ Hits         2106     3035      +929     
- Misses       1651     3793     +2142     
- Partials      222      354      +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codysoyland
Copy link
Member Author

codysoyland commented Sep 3, 2024

LGTM although there are few tests failing.

Thanks @hectorj2f, I fixed those tests.

@hectorj2f hectorj2f merged commit 231ae3c into sigstore:main Sep 4, 2024
70 of 72 checks passed
@hectorj2f
Copy link
Collaborator

Thanks @codysoyland

@github-actions github-actions bot added this to the v1 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom trusted root target
2 participants