Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to support non-identity based cert as verifier #1318

Open
karaguo opened this issue Mar 19, 2024 · 1 comment
Open

Request to support non-identity based cert as verifier #1318

karaguo opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@karaguo
Copy link

karaguo commented Mar 19, 2024

Description

Based on clusterImagePolicy API, it has options to accept key, keyless authority. Can we also support non-identity based cert as verifier to verify signatures, such as https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/verify/verify.go#L239-L268

@karaguo karaguo added the enhancement New feature or request label Mar 19, 2024
@haydentherapper
Copy link
Contributor

haydentherapper commented Mar 20, 2024

I might suggest to align with future changes to the Cosign UI and other sigstore libraries, rather than taking in a certificate chain which contains a root & some number of intermediates, take in each of those as separate options. openssl has an example of such, that a root is referred to as "trusted" CA certificates, and intermediates are "untrusted" or chain building CA certificates. In sigstore/cosign#3464, this proposes using ca-roots and ca-intermediates, which I think is fine nomenclature.

The benefit of this is that the caller is not responsible for constructing the valid chain, the library is. And if you have a more complex PKI, for example multiple intermediates issued by a root, you don't need to provide multiple chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants